Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TDL-20208 Add warning message for pro account plan. #49

Open
wants to merge 6 commits into
base: TDL-20359-add-custom-exception-handling
Choose a base branch
from

Conversation

prijendev
Copy link

@prijendev prijendev commented Aug 24, 2022

Description of change

  • Added logic to skip 403 error in the discover mode for satisfaction_ratings and time_entries streams and provide a warning message to upgrade the account to the pro plan.
  • Added unit test to verify the following scenarios
    • Tap raise error for invalid token
    • Tap raise error for invalid domain
    • Tap provide warning message for free account
    • Tap does raise any error or does not provide any warning message for the pro account.

Manual QA steps

Risks

Rollback steps

  • revert this branch

@prijendev prijendev changed the title Added warning message for pro account plan. TDL-20208 Add warning message for pro account plan. Aug 25, 2022
Comment on lines 154 to 156
LOGGER.warning("The `Surveys` and the `Timesheets` features are not supported in your current plan. "\
"So, Data collection cannot be initiated for satisfaction_ratings and time_entries streams. "\
"Please upgrade your account to `Pro` plan to use it.")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is not the only reason so we should write this in might context like this might be the reason so check your account.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated warning message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants