TDL 17738 sync conversations stream correctly #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prijendev
changed the base branch from
master
to
TDL-20356-update-function-based-to-class-based
dbshah1212
reviewed
Sep 8, 2022
…://github.com/singer-io/tap-freshdesk into TDL-17738-sync-conversations-stream-correctly
…L-17738-sync-conversations-stream-correctly
dbshah1212
approved these changes
Sep 15, 2022
| Overwrite updated__at value. | ||
| """ | ||
| if record.get("last_edited_at"): | ||
| record["updated_at"] = max(record["updated_at"], record["last_edited_at"]) |
There was a problem hiding this comment.
Please add comments here regarding why the above changes are needed, and we can't use updated_at directly.
There was a problem hiding this comment.
Added code comments to explain above if condition.
tap_freshdesk/test_streams.py
Outdated
| "tickets": {"updated_at": "2020-03-16T00:00:00Z"}, | ||
| } | ||
|
|
||
| @parameterized.expand([ |
There was a problem hiding this comment.
Add comments like #["test_name", "selected_streams"......] to explain each arguments.
There was a problem hiding this comment.
Added comments to explain arguments.
…L-17738-sync-conversations-stream-correctly
savan-chovatiya
approved these changes
Sep 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
updated_atvalue bylast_edited_atfield if it is available.last_edited_atisnot Nonethen assign it's value toupdated_atfield.Manual QA steps
last_edited_atfield value, checkupdated_atis updated.last_edited_atfield null value, checkupdated_atis not updated.Risks
Rollback steps