Tdl 20909 Add premade reports with dimensions filters #31
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Adds two premade reports,
conversions_report
andin_app_purchases
, and hard codes their dimension filters in the client class.Manual QA steps
in_app_purchases
conversions_report
manually, by running the report withisConversionEvent
selected and without, and confirming the records received are the same.conversions_report
without the filter syncs more recordsin_app_purchases
can complete a sync, but not records were synced.Risks
in_app_purchases
synced the correct rows.Rollback steps