added retry backoff for google-ads unauthorised error #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdeshmukh15
requested changes
May 31, 2023
tap_google_ads/streams.py
Outdated
| @@ -230,13 +230,14 @@ def on_giveup_func(err): | |||
| @backoff.on_exception(backoff.expo, | |||
| (GoogleAdsException, | |||
| ServerError, TooManyRequests, | |||
| ReadTimeout, | |||
| ReadTimeout, | |||
There was a problem hiding this comment.
Is this space really needed?
| AttributeError), | ||
| max_tries=5, | ||
| jitter=None, | ||
| giveup=should_give_up, | ||
| on_giveup=on_giveup_func, | ||
| logger=None) | ||
| @backoff.on_exception(backoff.expo, Unauthorized, max_tries=5, jitter=None,logger=None) |
There was a problem hiding this comment.
Can't we append Unauthorized in 1st backoff itself?
There was a problem hiding this comment.
the above exceptions have a on_giveup handler, which is not needed and does not work with this specific exception class hence added a new decorator
cngpowered
commented
May 31, 2023
kethan1122
reviewed
Jun 2, 2023
Comment on lines
+107
to
+110
| try: | ||
| make_request(mocked_google_ads_client, "", "") | ||
| except Unauthorized: | ||
| pass |
There was a problem hiding this comment.
Use self.assertRaises instead of try-catch block
kethan1122
suggested changes
Jun 2, 2023
| @@ -7,7 +7,7 @@ | |||
| from singer import utils, metrics | |||
| from google.protobuf.json_format import MessageToJson | |||
| from google.ads.googleads.errors import GoogleAdsException | |||
| from google.api_core.exceptions import ServerError, TooManyRequests | |||
| from google.api_core.exceptions import ServerError, TooManyRequests, Unauthorized | |||
There was a problem hiding this comment.
looking at the error in CCI logs, the import has to be Unauthenticated
RushiT0122
requested changes
Jun 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
This adds retry for intermittent 401 auth errors
Jira: TDL-23120
QA steps
Risks
Rollback steps