Add addressable list fields #34
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
August 20, 2021 15:19
* schema changes to contacts stream for expanded fields * adding get_addressable_list() method to contacts stream
* add `metadata` param to BaseStream get_records() method * update get_addressable_list() method to check if fields are selected in steam metadata
hpatel41
added a commit
that referenced
this pull request
Sep 26, 2022
* added addressable list fields in for contacts stream * resolve pylint error * resolve pylint error * resolved multiple record bug in transform_times * resolved pylint error * updated the code to do API call if we have some record for addresable fields and updated bookmark test case * updated bookmark test case * updated the code to do API calls if has_more is true and store only ids for addressable list fields * resolved pylint error * reverted notes schema change * merged skipping condiitons * added unittest * updated variable in unittest
sgandhi1311
added a commit
that referenced
this pull request
Dec 12, 2022
* TDL-15031: Add addressable list fields (Copy of PR #34) (#58) * added addressable list fields in for contacts stream * resolve pylint error * resolve pylint error * resolved multiple record bug in transform_times * resolved pylint error * updated the code to do API call if we have some record for addresable fields and updated bookmark test case * updated bookmark test case * updated the code to do API calls if has_more is true and store only ids for addressable list fields * resolved pylint error * reverted notes schema change * merged skipping condiitons * added unittest * updated variable in unittest * TDL-19860: Need to update Primary keys for Company_Attributes & Contacts streams (#56) * updated PK for company_attributes and used hash of records as the PK * updated setup.py to install parameterized for unittests * added activate version for company and contact attributes stream * updated test case and code * updated test cases * fix CCi build failure * updated code and comments * updated README file * TDL-19844: Add custom exception handling (#54) * Added custom exception handling * Make pylint happy * Added unit tests * Added backoff for 5xx error * Added/updated unit tests * Added/updated unit tests * Updated unit tests * Updated cconfig.yml * Added unit test case for json decode * Added unit test case for backoff * Added error code in logger message * make pylint happy Co-authored-by: harshpatel4crest <harsh.patel4@crestdatasys.com> * TDL-19859: Upgrade API version and related new fields (#53) * upgraded intercom to V2.5 and added missing fields * added all fields test case * resolved integration test failure * updated api version in readme file * TDl-19845: Add missing tap tester & unit tests (#57) * Added missing integration & unit tests * Fixed unit test failure * Fixed unit test failure * Updated unit test * Added unit test for init and transform * Updated expected PKs * Fixed unit test * Updated inturrpted_sync test * Updated transform unit test * Resolved review comment * Resolved review comment and added workaround for live data * Removed get_logger * Removed get_logger * updated pagination and interrupted sync test cases * updated tap-tester tests * updated tap-tester test code * resolved unittest failure Co-authored-by: harshpatel4crest <harsh.patel4@crestdatasys.com> * TDL-19892: Use common API calls for parent's data for parent/child streams (#55) * added code change to use common API call for parent-child streams * resolved pylint error * resolved unittest error * updated the code * added unittests * fix unittest failure * resolve review comments * updated the code * updated the code * updated comment * updated the location of get_parent_data method for admins and admin_list * added comment for admin and admin_list * updated comment and unittest * resolve unittest failure * updated comment and removed redundant code of returning state when parent and child are not selected * added tap-tester test for parent-child syncing * updated bookmark test case * updated test case name * updated setup.py file * resolve pylint error * update setup.py and changelog.md Co-authored-by: savan-chovatiya <80703490+savan-chovatiya@users.noreply.github.com> Co-authored-by: Sourabh Gandhi <sgandhi@talend.com>
|
Addressed by #59 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
adding addressable list objects for the contacts stream as per TDL-6648
Manual QA steps
Risks
Rollback steps