TDL-17002: Make the logger messages more descriptive #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbshah1212
reviewed
Dec 30, 2021
| else: | ||
| scrolling = False | ||
|
|
||
| records = transform_json(response, self.tap_stream_id, self.data_key) |
There was a problem hiding this comment.
We did not remove it, just shifted above the condition as it contains the records, we can print the logger containing the number of records and then the logger of "Syncing next page" if the response contains the next page value.
dbshah1212
approved these changes
Dec 31, 2021
KrisPersonal
approved these changes
Dec 31, 2021
dmosorast
requested changes
Dec 31, 2021
dmosorast
requested changes
Dec 31, 2021
dmosorast
requested changes
Jan 4, 2022
tap_intercom/streams.py
Outdated
| @@ -223,10 +222,10 @@ class Admins(FullTableStream): | |||
| parent = AdminList | |||
|
|
|||
| def get_records(self, bookmark_datetime=None, is_parent=False) -> Iterator[list]: | |||
| LOGGER.info("Syncing: {}".format(self.parent.tap_stream_id)) | |||
There was a problem hiding this comment.
This should be self.tap_stream_id instead of self.parent.tap_stream_id. Apologies for being so particular, but these kinds of log lines can cause a large amount of confusion.
There was a problem hiding this comment.
Updated to self.tap_stream_id
dmosorast
approved these changes
Jan 4, 2022
Merged
KrisPersonal
pushed a commit
that referenced
this pull request
Jan 5, 2022
* TDL-17000: fix breaking changes and TDL-17017: Fix bookmark for conversation_parts stream. (#45) * Reverted conversation_parts to full_table for parent as V1.1.3 * Updated bookmark test to handle conversation_parts * Updated comments * Added code to select parent_stream if only child stream is selected same as v1.1.3 * Added code comments * Resolved review comment * Resolved review comment * Added code comments * Added bookmark mechanism for conversation_parts same as before but independant of conversations * Added code comments * Added query paramater to get conversations greater and equal to bookmark * Adding changes of PR42 for better unit tests * Added logger messages * Added unit test * Updated unit test * Updated unit test * Updated variables in unit test * Added time_extracted for conversation_parts * Resolved review comments * Added companies to untestable for bookmark test * Reverted changes of last commit * Tdl 17003 Added back missing field for contact streams (#43) * Reverted the logic as per old version * Removed leads as well as it is not supported by tap * Tdl 17006 revert back companies to incremental (#44) * Reverted companies to incremental stream * Debuging integration test * Removed print statement * Added companies to untestable for bookmark test * TDL-17002: Make the logger messages more descriptive (#46) * added logger messages * removed unnecessary loggers * removed unnecessary loggers * updated the code to use stream name instead of parent stream name Co-authored-by: savan-chovatiya <80703490+savan-chovatiya@users.noreply.github.com> Co-authored-by: Umang Agrawal <80704207+umangagrawal-crest@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
TDL-17002: Make the logger messages more descriptive
Manual QA steps
Risks
Rollback steps