check for empty breadcrumb the right way #58
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
When validating the state, check for an empty breadcrumb by checking for an empty list instead of an empty tuple.
Manual QA steps
Had a client that was stuck in an infinite loop since they de-selected the stream that was bookmarked as
currently_syncing
. Was able to verify that this fix takes them out of the looping behavior.Risks
None since this function was not working correctly before
Rollback steps
Revert this change