Convert catalog to dict. Resolves is not subscriptable error
#76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @haleemur, thanks for your contribution! In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. |
|
You did it @haleemur! Thank you for signing the Singer Contribution License Agreement. |
haleemur
force-pushed
the
fix/catalog-attribute-access
branch
from
f553404 to
0f865cc
Compare
|
@cmerrick a couple of years late, but noticed that the CI has not run any checks on this branch in that time. I rebased it on current master branch just now. I'm unsure how best to proceed to get this merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
I tried using
singer-io/tap-marketowith meltano v1.78.0.The extract failed at
validate_statebecause the catalog is not subscriptable.The
Catalogclass has ato_dictmethod defined here:https://github.com/singer-io/singer-python/blob/master/singer/catalog.py#L52
converting the catalog to a dictionary allows lookup by key
Manual QA steps
installed this branch locally on my meltano project & the etl works without issues with my marketo instance
Risks
Rollback steps