Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable SSL #80

Merged
merged 2 commits into from
Feb 28, 2020
Merged

Enable SSL #80

merged 2 commits into from
Feb 28, 2020

Conversation

nick-mccoy
Copy link
Contributor

Description of change

ssl is a config property for tap-postgres, but it wasn't actually being used when opening a connection to the db.

This PR adds the sslmode param when opening a connection if the config prop ssl = true

QA steps

  • automated tests passing
  • manual qa steps passing (list below)
  • Added ssl: true to tap-tester and verified that it passed locally

Risks

connections that have ssl turned on but, for some reason, have it disabled on their db will start failing.

Rollback steps

  • revert this branch

@nick-mccoy nick-mccoy changed the title Turn on ssl Enable SSL Feb 27, 2020
@nick-mccoy nick-mccoy merged commit ab6d73f into master Feb 28, 2020
@nick-mccoy nick-mccoy deleted the turn-on-ssl branch February 28, 2020 21:00
@nick-mccoy nick-mccoy mentioned this pull request Mar 5, 2020
Merged
2 tasks
@alastairstuart alastairstuart mentioned this pull request Sep 18, 2020
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KAllan357 KAllan357 KAllan357 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nick-mccoy @KAllan357