Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TDL-23255 Upgrade Shopify API to 2023_04 #178

Merged
merged 23 commits into from
Sep 28, 2023
Merged

TDL-23255 Upgrade Shopify API to 2023_04 #178

merged 23 commits into from
Sep 28, 2023

Conversation

dsprayberry
Copy link
Contributor

@dsprayberry dsprayberry commented Sep 21, 2023 •
edited
Loading

Description of change

  • Updates the Shopify SDK to 12.3.0
  • Updates API version used to 2023_04
  • Incorporates changes listed below to schemas
    • 2022_10 changes:
      • added merchant_of_record_app_id field to orders stream
      • removed total_price_usd field from orders stream
    • 2023_01 changes:
      • added payment_details field to transactions stream
      • added payment_id field to transactions stream
    • 2023_04 changes:
      • removed gateway field from orders stream
      • removed payment_details object from orders stream
      • removed processing_method field from orders stream
      • added total_unsettled_set object to transactions stream
      • added current_total_additional_fees_set object to orders stream
      • added original_total_additional_fees_set object to orders stream
  • Version bump & changelog

QA steps

  • automated tests passing
  • manual qa steps passing (list below)

Risks

Should not be merged without Shopify app update

Rollback steps

  • revert this branch

leslievandemark and others added 22 commits September 20, 2023 14:44
@leslievandemark
upgrade shopify api to 23-04
b63d570
@leslievandemark
try parallel circle tests
0670e96
@leslievandemark @luandy64
Remove fulfillment_service from line_item resource for 2022_10
364273d 
-----------------------------

Co-authored-by: alu <alu@talend.com>
@leslievandemark
Updated config.yml
d0fc07e
@leslievandemark
Updated config.yml
980e061
@leslievandemark
Updated config.yml
f42d7b9
@leslievandemark
Updated config.yml
0082877
@leslievandemark
update schema name to avoid test collisions
048d2f7 
-----------------------------

Co-authored-by: Dylan Sprayberry <dsprayberry@talend.com>
@leslievandemark
Merge branch 'upgrade-shopify-api-2304' of github.com:singer-io/tap-s…
cb489a3 
…hopify into upgrade-shopify-api-2304
@leslievandemark
decrease parallelism for rate limiting errors
58ca778 
-----------------------------

Co-authored-by: Dylan Sprayberry <dsprayberry@talend.com>
@leslievandemark
add fulfillment_service back in since it's nested
a3ad7a9 
-----------------------------

Co-authored-by: Dylan Sprayberry <dsprayberry@talend.com>
@leslievandemark
Remove deprecated orders.total_price_usd field for 2022_10
7d98229 
-----------------------------

Co-authored-by: Dylan Sprayberry <dsprayberry@talend.com>
@leslievandemark
Add new orders.merchant_of_record_app_id field
9d14f6e 
-----------------------------

Co-authored-by: Dylan Sprayberry <dsprayberry@talend.com>
@leslievandemark
add new transactions.payment_details fields 2023_01
b913845 
-----------------------------

Co-authored-by: Dylan Sprayberry <dsprayberry@talend.com>
@leslievandemark
Add new transactions.payment_id field for 2023_01
d14242c 
-----------------------------

Co-authored-by: Dylan Sprayberry <dsprayberry@talend.com>
@leslievandemark
make jsonvalidator happy
a41fe1f 
-----------------------------

Co-authored-by: Dylan Sprayberry <dsprayberry@talend.com>
@leslievandemark
Remove processing_method, payment_details, gateway for 2023_04
bf87a42 
-----------------------------

Co-authored-by: Dylan Sprayberry <dsprayberry@talend.com>
@leslievandemark
Add total_unsettled_set object for 2023_04
e0c3050 
-----------------------------

Co-authored-by: Dylan Sprayberry <dsprayberry@talend.com>
@leslievandemark
Add current / original fees sets objects for 2023_04
509a9a3 
-----------------------------

Co-authored-by: Dylan Sprayberry <dsprayberry@talend.com>
@leslievandemark
Fix json and collapse newly added objects for readability
784e588 
-----------------------------

Co-authored-by: Dylan Sprayberry <dsprayberry@talend.com>
@leslievandemark
version_bump and changelog
7267728 
-----------------------------

Co-authored-by: Dylan Sprayberry <dsprayberry@talend.com>
@leslievandemark
adjust parallelism to 2 so that we don't api calls per second limit
8a514ed 
-----------------------------

Co-authored-by: Dylan Sprayberry <dsprayberry@talend.com>
@bobbrodie
Copy link

@dsprayberry this is awesome. It's great to see this come through, and with a huge jump to a 2023 API. Really looking forward to this!

@dmosorast dmosorast merged commit 43b85b2 into master Sep 28, 2023
2 checks passed
@dmosorast dmosorast deleted the upgrade-shopify-api-2304 branch September 28, 2023 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luandy64 luandy64 luandy64 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dsprayberry @bobbrodie @luandy64 @dmosorast @leslievandemark