Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Base API URL #9

Merged
merged 5 commits into from
Jun 25, 2021
Merged

Update Base API URL #9

merged 5 commits into from
Jun 25, 2021

Conversation

luandy64
Copy link
Contributor

Description of change

This PR adds tests on top of the work done in #8

Manual QA steps

  • Ran the tap

Risks

  • Low. The change did not throw errors and data was returned

Rollback steps

  • revert this branch, bump the version

chrisgre and others added 5 commits June 16, 2021 14:35
@chrisgre
Update Toggle endpoint.
c057a37 
Toggl is updating the base url of their api to `api.track.toggl.com`, and is turning off traffic to the top level domain June 30th. This should take care of that switch.
@luandy64
Add circle context
fb8dfa6
@luandy64
Update circle config
6e91dd5
@luandy64
Call it what it is and updated path to unittests
cada0a3
@luandy64
Fix test
e2bb1b1
@luandy64 luandy64 merged commit 3640463 into master Jun 25, 2021
@luandy64 luandy64 deleted the pr-8 branch June 25, 2021 19:15
@luandy64 luandy64 mentioned this pull request Jun 25, 2021
Closed
@erinkcochran87 erinkcochran87 mentioned this pull request Jul 13, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmosorast dmosorast dmosorast approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@luandy64 @dmosorast @chrisgre