-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/validate form input #34
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cation_keys method.
…to use a set instead of a list
34cf563
to
56698ba
Compare
KAllan357
suggested changes
Jul 15, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a test and some coverage around a Form input with a prefix / suffix spaces? ex: " abc"
or "abc "
…d added corresponding unittest.
KAllan357
approved these changes
Jul 16, 2021
luandy64
added a commit
that referenced
this pull request
Jul 26, 2021
* Revert "Don't delete the old connection (#36)" This reverts commit 2e204f1. * Revert "Feature/validate form input (#34)" This reverts commit 323a987. * Revert "Add tap tester (#32)" This reverts commit 6ab681f. * Revert "Add exception handling tests (#33)" This reverts commit e13a860. * Revert "Add forms stream (#29)" This reverts commit 12c3d4e.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Implemented function that verifies the user input form ids are returned by the API as requested in TDL-12563
Manual QA steps
Risks
Rollback steps