Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/validate form input #34

Merged
merged 17 commits into from
Jul 16, 2021
Merged

Feature/validate form input #34

merged 17 commits into from
Jul 16, 2021

Conversation

0xpetersatoshi
Copy link

Description of change

Implemented function that verifies the user input form ids are returned by the API as requested in TDL-12563

Manual QA steps

Risks

Rollback steps

  • revert this branch

@0xpetersatoshi 0xpetersatoshi force-pushed the feature/validate-form-input branch from 34cf563 to 56698ba Compare July 14, 2021 20:29
Copy link

@KAllan357 KAllan357 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a test and some coverage around a Form input with a prefix / suffix spaces? ex: " abc" or "abc "

@KAllan357 KAllan357 merged commit 323a987 into master Jul 16, 2021
@KAllan357 KAllan357 deleted the feature/validate-form-input branch July 16, 2021 15:03
luandy64 added a commit that referenced this pull request Jul 26, 2021
luandy64 added a commit that referenced this pull request Jul 26, 2021
* Revert "Don't delete the old connection (#36)"

This reverts commit 2e204f1.

* Revert "Feature/validate form input (#34)"

This reverts commit 323a987.

* Revert "Add tap tester (#32)"

This reverts commit 6ab681f.

* Revert "Add exception handling tests (#33)"

This reverts commit e13a860.

* Revert "Add forms stream (#29)"

This reverts commit 12c3d4e.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants