Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to OAuth2 #66

Merged
merged 10 commits into from
Oct 14, 2020
Merged

Update to OAuth2 #66

merged 10 commits into from
Oct 14, 2020

Conversation

cosimon
Copy link
Contributor

@cosimon cosimon commented Oct 13, 2020

Description of change

Update tap-xero to use OAuth2

Manual QA steps

  • We ran the tests locally, but the tests will not pass until the connections-service is also doing OAuth2

Risks

  • We will need to do a major version bump of the tap to go with this change and then not bump the image_version until the connections-service is fully swapped over to OAuth2 and the app is released with Xero profile selection.

https://github.com/stitchdata/connections-service/pull/1132
https://github.com/stitchdata/connections-service/pull/1126
https://github.com/stitchdata/app/pull/1155

Rollback steps

  • revert this branch

@cosimon cosimon changed the title Update to oauth 2 Update to OAuth2 Oct 13, 2020
@cosimon cosimon merged commit 0672df6 into master Oct 14, 2020
@dsprayberry dsprayberry deleted the update-to-oauth-2 branch January 25, 2022 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant