-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TDL-20724 : Use Incremental Export endpoint for Users stream #127
TDL-20724 : Use Incremental Export endpoint for Users stream #127
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, my only concern is the loss of the chat_only
field on the new endpoint. If thats an important field for customers then maybe this should be a major version bump, its worth talking to product about.
@leslievandemark Sure, will ask the product about this. |
* WIP add satisfaction_ratings stream to test coverage * Push current test and spike on future improvements --------- Co-authored-by: btowles <btowles@stitchdata.com>
* Reproduce infinite loop behaviour in unittest 'test_user_infinite_loop.py' and correct that behaviour * Correct exception mesaage in unittest * change logger message * correct logger message * add comment in streams.py and add 2sec window test case * add comment in streams.py and add 2sec window test case * Change exception message * Correct comment message * resolved unitetst error * update behaviour for 1 second window size * changelog and verison bump --------- Co-authored-by: Rushikesh Todkar <98420315+RushiT0122@users.noreply.github.com> Co-authored-by: kethan1122 <kcherukuri@talend.com>
…m:singer-io/tap-zendesk into TDL-20724-incremental-export-users-stream
… is no longer needed.
… is no longer needed.
…m:singer-io/tap-zendesk into TDL-20724-incremental-export-users-stream
… is no longer needed.
…m:singer-io/tap-zendesk into TDL-20724-incremental-export-users-stream
…io#127) * Added code for Incremental export API for Users stream * removed unused import * Fixed the expected keys for all fields test.
Description of change
Manual QA steps
Risks
Rollback steps