Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TDL-20724 : Use Incremental Export endpoint for Users stream #127

Merged
merged 31 commits into from
May 25, 2023

Conversation

shantanu73
Copy link
Contributor

@shantanu73 shantanu73 commented May 10, 2023

Description of change

  1. Added code to implement Incremental Export endpoint for User's stream
  2. Fixed all fields test with correct set of expected keys

Manual QA steps

  • Wrote a script to test sync time for existing & incremental export api changes.

Risks

  • Low risk

Rollback steps

  • revert this branch

Copy link
Contributor

@leslievandemark leslievandemark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, my only concern is the loss of the chat_only field on the new endpoint. If thats an important field for customers then maybe this should be a major version bump, its worth talking to product about.

@shantanu73
Copy link
Contributor Author

This looks good, my only concern is the loss of the chat_only field on the new endpoint. If thats an important field for customers then maybe this should be a major version bump, its worth talking to product about.

@leslievandemark Sure, will ask the product about this.

* WIP add satisfaction_ratings stream to test coverage

* Push current test and spike on future improvements

---------

Co-authored-by: btowles <btowles@stitchdata.com>
karanpanchal-crest and others added 18 commits May 25, 2023 11:40
* Reproduce infinite loop behaviour in unittest 'test_user_infinite_loop.py' and correct that behaviour

* Correct exception mesaage in unittest

* change logger message

* correct logger message

* add comment in streams.py and add 2sec window test case

* add comment in streams.py and add 2sec window test case

* Change exception message

* Correct comment message

* resolved unitetst error

* update behaviour for 1 second window size

* changelog and verison bump

---------

Co-authored-by: Rushikesh Todkar <98420315+RushiT0122@users.noreply.github.com>
Co-authored-by: kethan1122 <kcherukuri@talend.com>
…m:singer-io/tap-zendesk into TDL-20724-incremental-export-users-stream
…m:singer-io/tap-zendesk into TDL-20724-incremental-export-users-stream
@shantanu73 shantanu73 merged commit 63dd6af into master May 25, 2023
Karthipillai pushed a commit to MarletteFunding/singer-tap-zendesk that referenced this pull request Oct 2, 2023
…io#127)

* Added code for Incremental export API for Users stream

* removed unused import

* Fixed the expected keys for all fields test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants