Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get page_size from config or use default #141

Merged
merged 3 commits into from
Oct 18, 2023

Conversation

bryantgray
Copy link
Contributor

Description of change

  • A page size of 100 can sometimes be too large for zendesk to handle.
  • Page size is now an advanced option, with a default value of 100.
    • can be set to any integer between 1 and 1000 (inclusive)

Manual QA steps

  • Verified adjusting page size down will lead to a successful response from Zendesk
  • Values outside of 1 - 1000 will cause the default page size (100) to be used

Risks

  • Low. Only requests that were previously using page size will use the custom page size, if specified.

Rollback steps

  • revert this branch

@bryantgray bryantgray merged commit 407bd5d into master Oct 18, 2023
@bryantgray bryantgray deleted the TDL-24362/configurable-page-size branch October 18, 2023 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants