Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ticket forms #15

Merged
merged 3 commits into from
Jul 25, 2018
Merged

add ticket forms #15

merged 3 commits into from
Jul 25, 2018

Conversation

nick-mccoy
Copy link
Contributor

Adding ticket_forms stream to tap

@nick-mccoy nick-mccoy requested a review from dmosorast July 25, 2018 15:37
Copy link
Contributor

@dmosorast dmosorast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment on the extra schema key as we discussed. Otherwise, looks good to me!

"string"
]
},
"custom_field_options": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this is in our ticket_fields schema, might be a good idea to make it a subschema reference so that we can share the properties, in case it gets changed? Looks like they're the same right now, so no reason to make it here, but thought I'd mention :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, this isn't in the schema on the API docs, should probably be removed if we can't get it. https://developer.zendesk.com/rest_api/docs/core/ticket_forms

@nick-mccoy nick-mccoy merged commit 34d3590 into master Jul 25, 2018
@nick-mccoy nick-mccoy deleted the add_ticket_forms branch July 25, 2018 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants