Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TDL-24768: Enhance tap performance #154

Merged
merged 4 commits into from
Nov 19, 2024
Merged

TDL-24768: Enhance tap performance #154

merged 4 commits into from
Nov 19, 2024

Conversation

prijendev
Copy link
Contributor

Description of change

Hotfix for PR#150.

  • Tap failed when no ticket_audits or ticket_comments were selected.

Manual QA steps

  • Select tickets only and run sync mode successfully.
  • Select tickets,tickets_audit and run sync mode successfully.
  • Tried all the permutations and combination for selection and run sync mode successfully.
  • Run the sync mode by selection all the streams simultaneously and run sync mode successfully.

@prijendev prijendev merged commit 93980f8 into master Nov 19, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@somethingmorerelevant somethingmorerelevant somethingmorerelevant approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@prijendev @somethingmorerelevant