Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce log noise #28

Merged
merged 2 commits into from
Sep 17, 2019
Merged

Reduce log noise #28

merged 2 commits into from
Sep 17, 2019

Conversation

luandy64
Copy link
Contributor

The Transformer was being created for each record, but now we create it once per stream.

dmosorast
dmosorast approved these changes Sep 16, 2019
View reviewed changes
Copy link
Contributor

@dmosorast dmosorast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@luandy64 luandy64 merged commit e6f4bb3 into master Sep 17, 2019
@luandy64 luandy64 deleted the reduce-log-noise branch September 17, 2019 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmosorast dmosorast dmosorast approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@luandy64 @dmosorast @cosimon