Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added error message, bumped version to 1.5.1 #44

Merged
merged 2 commits into from
Sep 17, 2020
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
added error message, bumped version to 1.5.1
Jacob Baca committed Sep 17, 2020
commit af108b8238a398e507ca430ee93ea13738c1bd26
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
# Changelog

## 1.5.1
* Add error message to go along with assert

## 1.5.0
* Add date windowing to users stream and satisfaction ratings stream [#42](https://github.com/singer-io/tap-zendesk/pull/42)

2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
@@ -3,7 +3,7 @@
from setuptools import setup

setup(name='tap-zendesk',
version='1.5.0',
version='1.5.1',
description='Singer.io tap for extracting data from the Zendesk API',
author='Stitch',
url='https://singer.io',
2 changes: 1 addition & 1 deletion tap_zendesk/streams.py
Original file line number Diff line number Diff line change
@@ -376,7 +376,7 @@ def sync(self, state):
LOGGER.info("Detected Search API response size for this window is too large (> 50k). Cutting search window in half to %s seconds.", search_window_size)
continue
for satisfaction_rating in satisfaction_ratings:
assert parsed_start <= satisfaction_rating.updated_at
assert parsed_start <= satisfaction_rating.updated_at, "{} is not less than or equal to {}".format(parsed_start, satisfaction_rating.updated_at)
if bookmark < utils.strptime_with_tz(satisfaction_rating.updated_at) <= end:
# NB: We don't trust that the records come back ordered by
# updated_at (we've observed out-of-order records),