Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Break out of infinite loop and bookmark on date window end #46

Merged
merged 3 commits into from
Sep 23, 2020
Merged

Break out of infinite loop and bookmark on date window end #46

merged 3 commits into from
Sep 23, 2020

Conversation

jacobrobertbaca
Copy link
Contributor

Description of change

Break out of infinite loop and bookmark on date window end

Manual QA steps

  • ran a sync to make sure records were still coming through

Risks

  • low

Rollback steps

  • revert this branch

cosimon
cosimon requested changes Sep 23, 2020
View reviewed changes
tap_zendesk/streams.py Show resolved Hide resolved
tap_zendesk/streams.py Show resolved Hide resolved
@dmosorast dmosorast merged commit 625ee45 into master Sep 23, 2020
@dmosorast dmosorast deleted the fix/users-infinite-loop branch September 23, 2020 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmosorast dmosorast dmosorast left review comments

@cosimon cosimon cosimon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jacobrobertbaca @cosimon @dmosorast