Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backoff for all 5xx errors #93

Merged
merged 2 commits into from
Nov 30, 2021
Merged

Backoff for all 5xx errors #93

merged 2 commits into from
Nov 30, 2021

Conversation

prijendev
Copy link
Contributor

Description of change

  • Added back retry mechanism for all 5xx errors.
  • Added unit test cases for 524 and 520 errors.

Manual QA steps

  • Raise Httperror with status code 524 and 520 error and verify retry.

Risks

Rollback steps

  • revert this branch

kspeer825
kspeer825 approved these changes Nov 30, 2021
View reviewed changes
Copy link
Contributor

@kspeer825 kspeer825 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@KrisPersonal KrisPersonal merged commit 404a2bd into master Nov 30, 2021
@cosimon cosimon deleted the backoff-for-all-5xx-errors branch November 30, 2021 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KrisPersonal KrisPersonal KrisPersonal approved these changes

@kspeer825 kspeer825 kspeer825 approved these changes

@karanpanchal-crest karanpanchal-crest karanpanchal-crest approved these changes

@manand31 manand31 Awaiting requested review from manand31

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@prijendev @karanpanchal-crest @kspeer825 @KrisPersonal