fix: common link is detected as a video link (#1978)

* fix: common link is detected as a video link * chore: dart fixes --------- Co-authored-by: CatHood0 <santiagowmar@gmail.com>
singerdmx · Jul 6, 2024 · b00b29d · b00b29d
1 parent 018db26
commit b00b29d
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 6 deletions.
diff --git a/lib/src/utils/delta_x_utils.dart b/lib/src/utils/delta_x_utils.dart
@@ -20,7 +20,7 @@ class UnderlineSyntax extends md.DelimiterSyntax {
 class VideoSyntax extends md.LinkSyntax {
   VideoSyntax({super.linkResolver})
       : super(
-          pattern: r'\[',
+          pattern: r'\[!\[',
           startCharacter: _$lbracket,
         );
 
@@ -60,13 +60,13 @@ final videoRule = hmd.Rule('video', filters: ['iframe', 'video'],
       if (!_youtubeVideoUrlValidator.hasMatch(src ?? '')) {
         return '<video>${child.outerHTML}</video>';
       }
-      return '[$content]($src)';
+      return '[![$content]($src)';
     }
     final src = node.getAttribute('src');
     if (src == null || !_youtubeVideoUrlValidator.hasMatch(src)) {
       return node.outerHTML;
     }
-    return '[$content]($src)';
+    return '[![$content]($src)';
   }
   //by now, we can only access to src
   final src = node.getAttribute('src');
@@ -76,5 +76,5 @@ final videoRule = hmd.Rule('video', filters: ['iframe', 'video'],
     return node.outerHTML;
   }
   final title = node.getAttribute('title');
-  return '[$title]($src)';
+  return '[![$title]($src)';
 });
diff --git a/test/utils/delta_x_test.dart b/test/utils/delta_x_test.dart
@@ -13,8 +13,11 @@ void main() {
       '<iframe src="https://www.youtube.com/embed/dQw4w9WgXcQ" title="YouTube video player"></iframe>';
 
   const htmlWithVideoTag =
-      '''<video src="https://www.youtube.com/embed/dQw4w9WgXcQ">Your browser does not support the video tag.</video> 
-''';
+      '<video src="https://www.youtube.com/embed/dQw4w9WgXcQ">Your browser does not support the video tag.</video>';
+
+  const htmlWithNormalLinkAndVideo =
+      '<a href="https://www.macrumors.com/" type="text/html">fdsfsd</a><br><video src="https://www.youtube.com/embed/dQw4w9WgXcQ">Your browser does not support the video tag.</video>';
+
   final expectedDeltaEmp = Delta.fromOperations([
     Operation.insert(
         'This is a normal sentence, and this section has greater emp'),
@@ -34,6 +37,13 @@ void main() {
     Operation.insert('\n'),
   ]);
 
+  final expectedDeltaLinkAndVideoLink = Delta.fromOperations([
+    Operation.insert('fdsfsd', {'link': 'https://www.macrumors.com/'}),
+    Operation.insert('\n\n'),
+    Operation.insert({'video': 'https://www.youtube.com/embed/dQw4w9WgXcQ'}),
+    Operation.insert('\n'),
+  ]);
+
   test('should detect emphasis and parse correctly', () {
     final delta = DeltaX.fromHtml(htmlWithEmp);
     expect(delta, expectedDeltaEmp);
@@ -53,4 +63,9 @@ void main() {
     final delta = DeltaX.fromHtml(htmlWithVideoTag);
     expect(delta, expectedDeltaVideo);
   });
+
+  test('should detect by different way normal link and video link', () {
+    final delta = DeltaX.fromHtml(htmlWithNormalLinkAndVideo);
+    expect(delta, expectedDeltaLinkAndVideoLink);
+  });
 }