Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The color for Bullets/Numbered lists counts/dots doesn't follow it's text. #1562

Closed
1 task done
adnan-nazir opened this issue Dec 4, 2023 · 25 comments
Closed
1 task done
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@adnan-nazir
Copy link

Is there an existing issue for this?

Flutter Quill version

flutter_quill: ^8.6.4

Other Flutter Quill packages versions

No response

Steps to reproduce

flutter_quill is not giving support to change the color of dots and numbers for both Bullets and Numbered Lists. There should be the ability to set the colors for this.
image

Expected results

There should be the ability to set the colors for Bullets/Numbered list counts/dots.

Actual results

There should be the ability to set the colors for Bullets/Numbered list counts/dots.

Code sample

Code sample
[Paste your code here]

Screenshots or Video

image

Logs

Logs
[Paste your logs here]
@adnan-nazir adnan-nazir added the bug Something isn't working label Dec 4, 2023
@singerdmx
Copy link
Owner

Hello there, on behalf the Flutter Quill Team I would like to thank you for opening your first issue. Your inputs and insights are valuable in shaping a stable and reliable version for all our users. Thank you for being part of the open-source community!

@adnan-nazir adnan-nazir changed the title Unable to change colour for Bullets/Numbered lists counts/dots colour are not changeable. Unable to change colour for Bullets/Numbered lists counts/dots colour. Dec 4, 2023
@EchoEllet
Copy link
Collaborator

Hi, thank you for the report, until now I'm not a Quill js expert and I haven't taken a deep look at QuillRawEditor yet

but tell me if you want me to ask another maintainer to take a look at this

@adil192 You might be interested

@adnan-nazir adnan-nazir changed the title Unable to change colour for Bullets/Numbered lists counts/dots colour. Unable to change colour for Bullets/Numbered lists counts/dots. Dec 4, 2023
@adnan-nazir
Copy link
Author

Thanks @freshtechtips for assigning this to @adil192.

@adil192
Copy link
Contributor

adil192 commented Dec 4, 2023

Sorry I don't have the time to be a maintainer. Please assign this to someone else

@EchoEllet
Copy link
Collaborator

Sorry I don't have the time to be a maintainer. Please assign this to someone else

Sure thing

@adnan-nazir
Copy link
Author

Hey @freshtechtips, can you please confirm if it's assigned to someone?

@EchoEllet
Copy link
Collaborator

Hey @freshtechtips, can you please confirm if it's assigned to someone?

Sorry, I really can't right now it's not up to me, well I can assign it to myself, but it will take a few months

Do you still want me to?

@EchoEllet EchoEllet self-assigned this Dec 5, 2023
@EchoEllet
Copy link
Collaborator

Example of customizing the color:

image

We just added that option in the dev branch

If that's what you want please confirm so I close the issue but it will take a while before it will published and breaking changes may introduced

If not, please tell me how we can help you?

@adnan-nazir
Copy link
Author

Thanks dear, yes.
Just one thing is this dynamic?
Like if i select a color red and start adding this list then both number/dot and list test will should be red.

@EchoEllet
Copy link
Collaborator

Thanks dear, yes. Just one thing is this dynamic? Like if i select a color red and start adding this list then both number/dot and list test will should be red.

No, it's static, you choose the color for all the items, and you have two options, one for the ordered and unordered list, and you change the font color as well background

is there anything else you want to?

@adnan-nazir
Copy link
Author

It should be dynamic as I mentioned above for smooth experience

@EchoEllet
Copy link
Collaborator

EchoEllet commented Dec 6, 2023

Thanks dear, yes. Just one thing is this dynamic? Like if i select a color red and start adding this list then both number/dot and list test will should be red.

Wait, you mean select the color red as a user for any item the user selects? that's not what we did and we can but we will have to change the quill delta and add more custom data so I don't think that's confirmed to official Quill Js

If you mean you want to change it and customize it then that's it

but if you want a different color for each item, then can I ask how will you pick a different color for each item?? you don't have much info for the current item

@EchoEllet
Copy link
Collaborator

It should be dynamic as I mentioned above for smooth experience

I'm not sure what you mean by dynamic?

@EchoEllet
Copy link
Collaborator

1¹32q3³

Is this a typo or something? because I still can't understand what you mean

@EchoEllet
Copy link
Collaborator

If we solved your issue then feel free to ask any other questions at any time, if not then please tell me more details so we can reopen it and working on it

@adnan-nazir adnan-nazir reopened this Dec 6, 2023
@adnan-nazir
Copy link
Author

Sorry for the typo.

Don't use your new changes you just made, ignore it.
Have you tried adding the lists after changing color to red?
Like select color to red from toolbar and add numbered lists you will see all the text in red but the color of numbers will be black. Numbers color should also be red.
Just give it a try please.

@adnan-nazir
Copy link
Author

Check attached screenshot, This is how its currently working.
Text is in red but numbers color is black that should also be red if I selected red color from toolbar or by controller.

If you think it will effect the other users then you can add a bool parameter instead of the parameters you added to enable and disable this functionality.

Screenshot_2023_1206_234251

@EchoEllet
Copy link
Collaborator

Sorry for the typo.

Don't use your new changes you just made, ignore it.
Have you tried adding the lists after changing color to red?
Like select color to red from toolbar and add numbered lists you will see all the text in red but the color of numbers will be black. Numbers color should also be red.
Just give it a try please.

Hi, by adding the lists after changing the color to red. What do you mean by that? Can you explain in more detail?
We are in the middle of other processes, so we can't get you very easily

That's why I want to ask you to explain in more deep and simple details

Because in the screenshots you attached,

I get it. You just want to change the font and background color

If that's not what you meant, then can you edit the issue

@EchoEllet
Copy link
Collaborator

Check attached screenshot, This is how its currently working.
Text is in red but numbers color is black that should also be red if I selected red color from toolbar or by controller.

If you think it will effect the other users then you can add a bool parameter instead of the parameters you added to enable and disable this functionality.

Screenshot_2023_1206_234251

Oh I get it know

@Usama-Naseer
Copy link

Hey @freshtechtips, Any update over this

@EchoEllet
Copy link
Collaborator

Hey @freshtechtips, Any update over this

We will work on it later

@EchoEllet
Copy link
Collaborator

image

Is this what you expected?

EchoEllet pushed a commit that referenced this issue Dec 13, 2023
@EchoEllet EchoEllet added the enhancement New feature or request label Dec 13, 2023
@EchoEllet EchoEllet changed the title Unable to change colour for Bullets/Numbered lists counts/dots. The color for Bullets/Numbered lists counts/dots doesn't follow it's text. Dec 13, 2023
@EchoEllet
Copy link
Collaborator

Hi again, I'm closing the issue as solved, if you have the time please confirm if it worked like you expected it to work.

@max-pfi
Copy link

max-pfi commented Apr 8, 2024

@ellet0
Hi, would it maybe be possible to also implement the static version for the color customization, like in the one screenshot you posted? In my case I don't use the colors in the quill editor but rather set the textstyle according to my current background so the dots/numbers always stay black.

@1SagarSharma7
Copy link

Not able to spot the backgroundColor property in the QuillEditorOrderedListElementOptions or QuillEditorUnOrderedListElementOptions,
in version 10.4.5

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

7 participants