Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typo): fix typo ClipboardServiceProvider.instacne #1983

Merged
merged 2 commits into from
Jul 7, 2024

Conversation

EchoEllet
Copy link
Collaborator

@EchoEllet EchoEllet commented Jul 7, 2024

Deprecate ClipboardServiceProvider.instacne as it's a typo, add ClipboardServiceProvider.instance and update usages.

The class ClipboardServiceProvider introduced in 9.4.0 that's not exported and developers would have to explicitly import it with the relative path with src and then ignore a warning, so removing the old property should not be considered as a breaking change, I deprecated it instead just in case.

Related Issues

This typo is caught by comment 2212361659.

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I titled the PR using Conventional Commits.
  • I did not modify the CHANGELOG.md nor the package version in pubspec.yaml files.
  • All existing and new tests are passing.
  • I have run the commands in ./scripts/before_push.sh and it all passed successfully

Breaking Change

Does your PR require developers to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate that with a ! in the title as explained in Conventional Commits).
  • No, this is not a breaking change.

@EchoEllet EchoEllet merged commit 3acc44e into master Jul 7, 2024
2 checks passed
@EchoEllet EchoEllet deleted the chore/fix-typo-clipboard-service-instance branch July 7, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants