if magnifier removes toolbar, restore it when it is hidden

[mtallenca]

Description

Magnifier is removing selection context menu, but not restoring the menu after it's dismissed. This PR fixes that bug

• Fix Selection menu doesn't display after drag #2046

Type of Change

• ✨ New feature: Adds new functionality without breaking existing features.
• 🛠️ Bug fix: Resolves an issue without altering current behavior.
• 🧹 Code refactor: Code restructuring that does not affect behavior.
• ❌ Breaking change: Alters existing functionality and requires updates.
• 🧪 Tests: Adds new tests or modifies existing tests.
• 📝 Documentation: Updates or additions to documentation.
• 🗑️ Chore: Routine tasks, or maintenance.
• ✅ Build configuration change: Changes to build or deploy processes.

[EchoEllet]

@mtallenca Thank you for the quick fix, working on moving this feature into its own separate file so more details would be helpful to address it correctly.

[mtallenca]

This is a flag only used by the magnifier. If the magnifier is going to hide the toolbar, it needs to restore the toolbar when dismissed. A better name would be _restoreToolbarAfterMagnifier

…

On Thu, Sep 19, 2024 at 3:08 PM Ellet ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In lib/src/editor/widgets/text/text_selection.dart <#2049 (comment)> : > @@ -181,6 +181,7 @@ class EditorTextSelectionOverlay { /// A copy/paste toolbar. OverlayEntry? toolbar; + bool _restoreToolbar = false; If yes, we probably need a better way to document it or maybe more specific name: /// Restore the selection context menu after the magnifier is dismissed.bool _restoreToolbar = false; Do you have suggestions? — Reply to this email directly, view it on GitHub <#2049 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAXMGLNZU6JI4CVVTZU6W33ZXNDPJAVCNFSM6AAAAABLHTT3OSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDGMJWHAZTGNJQGU> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[EchoEllet]

Thank you for confirming.