Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: RTL issues #2060

Merged
merged 3 commits into from
Jul 24, 2024
Merged

Fix: RTL issues #2060

merged 3 commits into from
Jul 24, 2024

Conversation

CatHood0
Copy link
Collaborator

@CatHood0 CatHood0 commented Jul 24, 2024

Description

As we know, we always have issues related with the RTL directionality. At this moment, the current implementation of List, Checkbox or Blockquote, force the direction to be LTR, even if the system language is a RTL.

To test this i use some languages as hebrew or arabic that are RTL (as far i know)

Before these changes

Before 1 Before 2(1)

After these changes

After1(1) After2 After3

Related Issues

Fix #1928

  • New feature: Adds new functionality without breaking existing features.
  • 🛠️ Bug fix: Resolves an issue without altering current behavior.
  • 🧹 Code refactor: Code restructuring that does not affect behavior.
  • Breaking change: Alters existing functionality and requires updates.
  • 🧪 Tests: Adds new tests or modifies existing tests.
  • 📝 Documentation: Updates or additions to documentation.
  • 🗑️ Chore: Routine tasks, or maintenance.
  • Build configuration change: Changes to build or deploy processes.

Suggestions

We really need to avoid harcode the widgets on the editor.

I'll try to separate the logic to another file and make more extensible soon

@CatHood0 CatHood0 marked this pull request as draft July 24, 2024 01:44
@CatHood0 CatHood0 added the enhancement New feature or request label Jul 24, 2024
@CatHood0 CatHood0 marked this pull request as ready for review July 24, 2024 01:57
@singerdmx singerdmx merged commit 2818d0f into singerdmx:master Jul 24, 2024
2 checks passed
@Eng-Mohamed-Elsayed
Copy link

ok how can add button ltr or rtl

@jonasbernardo
Copy link

It doesn't work, watch the video, its ontap only works as if it were in the ltr position

video.checkbox.rtl.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

problems when using languages ​​that use ltr instead of rtl
5 participants