-
Notifications
You must be signed in to change notification settings - Fork 835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: Move spellchecker service to extensions #2120
Chore: Move spellchecker service to extensions #2120
Conversation
|
||
static void setInstance(SpellcheckerService service) { | ||
static void setNewCheckerService(SpellCheckerService service) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might want to enable this service in the example as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll add it later. I'm still doing the documentation about the Feature to the README
_instance.setNewLanguageState(language: language); | ||
} | ||
|
||
static void turnOffService() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be a breaking change, though it hasn't been used yet.
I'm interested in knowing the reason for the naming changes if available.
Same for the static method setInstance
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed the names so that they made more sense in the context of what the service is in charge of doing. However
, as it is still an experimental feature for now, it is quite subject to change.
For example, with documents that have many spelling errors (if the Spell checker detects them) then the load could be greater than expected.
For this I am still looking for a solution to how Word
or LibreOffice
do it, which first show all the text, and then little by little let the UI
update the specific parts that are wrong, which avoids that drop in performance of the app
Or that, for example, suggestions
for words that are misspelled have not yet been implemented.
It is likely that I will soon change the names of the instances to be less confusing, but it would be in the update for Flutter Quill 11
Description
Since
SimpleSpellCheckerService
is a custom implementation that is not needed by default, was moved to Flutter Quill Extensions and can be used such as SuperClipboard implementation:And was fixed some issue with some missing characters while typing (this is for languages such as portuguese, deutsch, italian, etc)
Suggestions
Please, after update the version of the main repo, also update it into
flutter_quill_extensions
to avoid conflicts since the new version change the names of the classes and methods.