Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: include spell checker for example app #2127

Merged
merged 5 commits into from
Aug 20, 2024

Conversation

CatHood0
Copy link
Collaborator

@CatHood0 CatHood0 commented Aug 20, 2024

Description

Added the Spell-checker to the sample app which can be turned on or off at the user's discretion.

However, not only this was done but some code parts were added and fixed:

  • Added information about the Feature in the README
  • Fixed a bug where the editor placeholder is detected as text instead of virtual text which should be ignored
  • Updated simple_spell_checker to the latest version to fix issues with state and characters being lost when typing in the editor

Preview:

clideo_editor_41252a306f9b4127809fd227ae4bbdb6.mp4
  • New feature: Adds new functionality without breaking existing features.
  • 🛠️ Bug fix: Resolves an issue without altering current behavior.
  • 🧹 Code refactor: Code restructuring that does not affect behavior.
  • Breaking change: Alters existing functionality and requires updates.
  • 🧪 Tests: Adds new tests or modifies existing tests.
  • 📝 Documentation: Updates or additions to documentation.
  • 🗑️ Chore: Routine tasks, or maintenance.
  • Build configuration change: Changes to build or deploy processes.

@CatHood0 CatHood0 changed the title Feat: add spell checker for example app Feat: include spell checker for example app Aug 20, 2024
@CatHood0 CatHood0 marked this pull request as draft August 20, 2024 02:36
@CatHood0 CatHood0 marked this pull request as ready for review August 20, 2024 04:07
@singerdmx singerdmx merged commit 7ae1afe into singerdmx:master Aug 20, 2024
2 checks passed
@CatHood0 CatHood0 removed the request for review from EchoEllet August 20, 2024 06:17
@CatHood0 CatHood0 deleted the add_spell_checker_for_example branch August 23, 2024 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants