Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Assertion Failure in line.dart When Editing Text with Block-Level Attributes #2174

Merged
merged 14 commits into from
Sep 1, 2024

Conversation

AtlasAutocode
Copy link
Collaborator

Description

Editing text with block attributes failed to show text until cursor moved. Assertion failure indicated that block level attributes were being applied to inline text whereas they should only be applied to line endings. The assert failure prevented code from updating the display. However, the root cause was in the QuillController replaceText function which incorrectly retained block attributes.

Related Issues

Type of Change

  • New feature: Adds new functionality without breaking existing features.
  • [ X ] 🛠️ Bug fix: Resolves an issue without altering current behavior.
  • 🧹 Code refactor: Code restructuring that does not affect behavior.
  • Breaking change: Alters existing functionality and requires updates.
  • 🧪 Tests: Adds new tests or modifies existing tests.
  • 📝 Documentation: Updates or additions to documentation.
  • 🗑️ Chore: Routine tasks, or maintenance.
  • Build configuration change: Changes to build or deploy processes.

@singerdmx singerdmx merged commit cab5a9b into singerdmx:master Sep 1, 2024
2 checks passed
@AtlasAutocode AtlasAutocode deleted the block_assert branch September 15, 2024 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants