Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow backspace at start of document to remove block style and header style #2198

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

agata
Copy link
Contributor

@agata agata commented Sep 9, 2024

Description

This is a fix for #2180. It adjusts behavior so that pressing backspace at the beginning of a document when the cursor is on a header/block will remove the header/block style. This allows styles to be removed using only keyboard operations, without needing to use the toolbar, thereby improving convenience.

2024-09-10.2.01.55.mp4

This pull request will slightly modify existing behavior.

Related Issues

Type of Change

  • New feature: Adds new functionality without breaking existing features.
  • 🛠️ Bug fix: Resolves an issue without altering current behavior.
  • 🧹 Code refactor: Code restructuring that does not affect behavior.
  • Breaking change: Alters existing functionality and requires updates.
  • 🧪 Tests: Adds new tests or modifies existing tests.
  • 📝 Documentation: Updates or additions to documentation.
  • 🗑️ Chore: Routine tasks, or maintenance.
  • Build configuration change: Changes to build or deploy processes.

Suggestions

@CatHood0
Copy link
Collaborator

CatHood0 commented Sep 9, 2024

Do you test these changes if the document is more than 1 line?

@singerdmx
Copy link
Owner

@agata can you confirm you test these changes that the document is more than 1 line

@agata
Copy link
Contributor Author

agata commented Sep 9, 2024

@singerdmx @CatHood0

Could you please clarify whether you are referring to automated tests, such as unit tests, or to manual testing when you mention 'test' in this context?

In manual operation tests, it functions correctly even in documents containing multiple lines. Please see the screencast here.

2024-09-10.2.23.30.mp4

@singerdmx singerdmx merged commit f351a80 into singerdmx:master Sep 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to Delete Heading 1 at the Beginning of a Line with Backspace
3 participants