Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Backspace handling at the start of blocks in delete rules #2199

Merged

Conversation

agata
Copy link
Contributor

@agata agata commented Sep 9, 2024

Description

Adjusts the handling of the backspace key at the start of blocks. It introduces a condition to delete the empty previous line and skip the merging action if the backspace key is pressed, preserving the current block's style and integrity. This change ensures a more intuitive editing experience.

2024-09-10.2.10.25.mp4

This resolves the issue where, when wanting to move content to the top of a document by pressing backspace to delete empty lines, such as within code blocks, the block style is unintentionally removed. The behavior is similar to that of the message input field in Slack.

This pull request will slightly modify existing behavior.

Related Issues

Type of Change

  • New feature: Adds new functionality without breaking existing features.
  • 🛠️ Bug fix: Resolves an issue without altering current behavior.
  • 🧹 Code refactor: Code restructuring that does not affect behavior.
  • Breaking change: Alters existing functionality and requires updates.
  • 🧪 Tests: Adds new tests or modifies existing tests.
  • 📝 Documentation: Updates or additions to documentation.
  • 🗑️ Chore: Routine tasks, or maintenance.
  • Build configuration change: Changes to build or deploy processes.

Suggestions

Adjusts the handling of the backspace key at the start of blocks. It introduces a condition to delete the empty previous line and skip the merging action if the backspace key is pressed, preserving the current block's style and integrity. This change ensures a more intuitive editing experience.
@singerdmx singerdmx merged commit f59836d into singerdmx:master Sep 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants