Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] Get readthedocs going #1098

Merged
merged 8 commits into from
Mar 13, 2023
Merged

[python] Get readthedocs going #1098

merged 8 commits into from
Mar 13, 2023

Conversation

johnkerl
Copy link
Member

@johnkerl johnkerl commented Mar 10, 2023

Issue and/or context: #1041

Changes:

Gets Python API docs into readthedocs.

Notes for Reviewer:

Current preview link (not on main): https://tiledbsoma.readthedocs.io/en/kerl-readthedocs-initial/python-api.html

There's more work to do but this gets the bulk of the docs available on the web for users to see. In particular readthdocs still needs a button poked manually; I don't have commit-triggers set up. Also some info about this (and R's pkgdown) needs to be written in this repo's developer wiki.

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and project coverage change: +30.14 🎉

Comparison is base (9414be7) 61.17% compared to head (745af57) 91.31%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1098       +/-   ##
===========================================
+ Coverage   61.17%   91.31%   +30.14%     
===========================================
  Files          81       30       -51     
  Lines        5906     2281     -3625     
===========================================
- Hits         3613     2083     -1530     
+ Misses       2293      198     -2095     
Flag Coverage Δ
python 91.31% <100.00%> (ø)
r ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
apis/python/src/tiledbsoma/__init__.py 100.00% <ø> (ø)
apis/python/src/tiledbsoma/_dense_nd_array.py 97.72% <100.00%> (ø)
apis/python/src/tiledbsoma/_sparse_nd_array.py 90.90% <100.00%> (ø)

... and 51 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@johnkerl johnkerl force-pushed the kerl/readthedocs-initial branch from 745af57 to 4e8712b Compare March 13, 2023 14:10
@johnkerl johnkerl requested a review from pablo-gar March 13, 2023 16:49
@@ -3,7 +3,8 @@
#
# Licensed under the MIT License.

"""Implementation of SOMA DenseNDArray.
"""
Implementation of SOMA DenseNDArray.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also prefer the newline between the triple quote and the text, but the Google guidelines for the docstrings don't have it. If we all like this style better, maybe we should make an exception but then we should make it consistent across the codebase.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ebezzi these were for sphinx/readthedocs render errors

unfortunately if it's a render error for webdocs vs a stylistic/guideline preference for google docs, we must go with the way that avoids a render error

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird 🤔 I was expecting napoleon to parse it correctly. Anyway, let's go with what works!

@johnkerl johnkerl merged commit 6ba1fc9 into main Mar 13, 2023
@johnkerl johnkerl deleted the kerl/readthedocs-initial branch March 13, 2023 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants