Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[c++] Integrate SOMAColumn: Arrow adapter methods, part 1 #3405

Open
wants to merge 23 commits into
base: main
Choose a base branch
from
+594 −500
Open

[c++] Integrate SOMAColumn: Arrow adapter methods, part 1 #3405

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
2022f23
SOMAColumn abstract class definition
XanthosXanthopoulos Nov 18, 2024
81007d0
Remove fmt::format
XanthosXanthopoulos Nov 20, 2024
457d5d4
Remove unneeded methods and member variables
XanthosXanthopoulos Nov 21, 2024
d6d91a3
Add concrete class wrapper for TileDB dimension
XanthosXanthopoulos Nov 21, 2024
1cf44f1
Add minimal testing for dimensions
XanthosXanthopoulos Nov 21, 2024
e7265fe
Replace string_view with string when returning column name, add curre…
XanthosXanthopoulos Dec 6, 2024
1baf795
Add concrete class wrapper for TileDB attribute
XanthosXanthopoulos Nov 21, 2024
df9fcab
Remove current_domain flag
XanthosXanthopoulos Nov 24, 2024
775e756
Replace string_view with string when returning column name, add curre…
XanthosXanthopoulos Dec 6, 2024
3511a32
Update CMake files
XanthosXanthopoulos Dec 12, 2024
264512a
Add minimal testing for dimensions
XanthosXanthopoulos Nov 21, 2024
34ed856
Misc fixes
XanthosXanthopoulos Nov 21, 2024
bebaddd
Add read test case
XanthosXanthopoulos Nov 22, 2024
176b576
Remove current_domain flag
XanthosXanthopoulos Nov 24, 2024
d06bfb7
Do not export soma column [skip ci]
XanthosXanthopoulos Nov 25, 2024
b8e8292
Replace string_view with string when returning column name, add curre…
XanthosXanthopoulos Dec 6, 2024
bd4edb4
Add function to extract data from ArrowTable into std::array
XanthosXanthopoulos Dec 6, 2024
ab46848
Migrate array creation to SOMAColumn
XanthosXanthopoulos Dec 6, 2024
6e0f7d1
Fix string current domain in unit dataframe tests
XanthosXanthopoulos Dec 6, 2024
ba58538
Fix current domain unit test on string dimension
XanthosXanthopoulos Dec 6, 2024
1ceef07
Remove unused methods
XanthosXanthopoulos Dec 6, 2024
77a01e1
Misc fixes
XanthosXanthopoulos Jan 14, 2025
01c3608
Address review comments
XanthosXanthopoulos Jan 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apis/r/tests/testthat/test-11-shape.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ test_that("SOMADataFrame shape", {
list(soma_joinid = c(0, 999), int_column = c(-10000, 10000)),
list(soma_joinid = c(0, 999), string_column = NULL),
list(string_column = NULL, int_column = c(-10000, 10000)),
list(string_column = c("apple", "zebra"), int_column = c(-10000, 10000))
list(string_column = c("", ""), int_column = c(-10000, 10000))
)

# Check the test configs themselves to make sure someone (ahem, me)
Expand Down
Loading