-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[python] Set soma_joinid
to always be an index column in the PointCloudDataFrame
class
#3563
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3563 +/- ##
==========================================
+ Coverage 86.22% 86.27% +0.04%
==========================================
Files 55 55
Lines 6410 6410
==========================================
+ Hits 5527 5530 +3
+ Misses 883 880 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
soma_joinid
to always be an index column in the PointCloudDataFrame
class
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release-1.15 release-1.15
# Navigate to the new working tree
cd .worktrees/backport-release-1.15
# Create a new branch
git switch --create backport-3563-to-release-1.15
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick --mainline 1 ec90ec7108b8b5943011fb256b4e1e4b9fd68952
# Push it to GitHub
git push --set-upstream origin backport-3563-to-release-1.15
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release-1.15 Then, create a pull request where the |
…CloudDataFrame` class (#3563) * Add back soma_joinid to PointCloudDataFrame * Update SOMA spatial encoding version
…ex column in the `PointCloudDataFrame` class (#3575) * [python] Set `soma_joinid` to always be an index column in the `PointCloudDataFrame` class (#3563) * Add back soma_joinid to PointCloudDataFrame * Update SOMA spatial encoding version * lint --------- Co-authored-by: Julia Dark <24235303+jp-dark@users.noreply.github.com>
Issue and/or context: sc-61690
Changes:
This changes the
soma_joinid
to be anindex_column
in thePointCloudDataFrame
. The initial implementation allowedsoma_joinid
to be an optional column. It was then dropped. Work on querying between observations/measurements and spatial data has motivated adding it back to improve querying byobs_id
andvar_id
.