feature: Adding ability to sort the import map alphabetically #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheMcMurder
commented
Aug 17, 2021
| prod: "memory://prod", | ||
| }, | ||
| describe(`/import-map.json`, () => { | ||
| let errorSpy; |
There was a problem hiding this comment.
Added this errorSpy so the tests wouldn't actually error to the console and clutter up the output
There was a problem hiding this comment.
I wanted to scope it as well so I moved the beforeAll and beforeEach blocks into the describe block
joeldenning
reviewed
Aug 17, 2021
joeldenning
approved these changes
Aug 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is something I'd like just because it would be convenient and make some of the larger import maps easier to read.
I'm pretty sure this is all I would need to change to support this feature.