Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Per version include/exclude not working #24

Open
thefat32 opened this issue Nov 27, 2023 · 0 comments
Open

Per version include/exclude not working #24

thefat32 opened this issue Nov 27, 2023 · 0 comments

Comments

@thefat32
Copy link

Include/exclude per version is not working.
From README

{
      versions: [
        // When the version is a string, the package's include and exclude lists
        // are applied
        ">= 17",

        // When the version is an object, the version's include and exclude lists
        // take priority over the package's include and exclude lists
        {
          version: "16.14.0",
          include: ["umd/**", "cjs/**"],
        },
      ],
}

The problem is at self-hosted-shared-dependencies.js in lines 310 and 310

In that context matchedVersion is always a string as it comes from npm's metadata. Line 247

thefat32 added a commit to thefat32/self-hosted-shared-dependencies that referenced this issue Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant