Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add in shebang #2

Merged
merged 1 commit into from
May 4, 2021
Merged

add in shebang #2

merged 1 commit into from
May 4, 2021

Conversation

jsmapr1
Copy link
Contributor

@jsmapr1 jsmapr1 commented May 3, 2021

Added shebang to bin file.

Copy link
Member

@joeldenning joeldenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Was it not working on Windows without this?

@joeldenning joeldenning merged commit ea5ef13 into single-spa:main May 4, 2021
@jsmapr1
Copy link
Contributor Author

jsmapr1 commented May 4, 2021

Don't know about windows. It wasn't working on mac. It worked if you explicitly called it with node (as you'd expect) but not just with a regular npm script as suggested in the docs.

@joeldenning
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants