use Str::contains instead of str_contains, implode error #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @cawa0505, Thank you for the PR. For next PRs please separate changes with code styles in different commits. |
wimurk
added a commit
that referenced
this pull request
Mar 10, 2021
* Update scripts.blade.php * Update DataTable.php * Update dropdown.blade.php * Update dropdown.blade.php * Update composer.json * Button field route issue Add a check if it already calls the relation * Update Button.php * Update Image.php * Update Button.php * Update image.blade.php * Update image.blade.php * Update image.blade.php * Update image.blade.php * Update composer.json * Fix issue with searchable relations * Add onclick to button field (#12) * Fix issue with multiple tables (#15) * Added filters to the package (#14) * Added filters to the package * Updated the docs * Update button.md * Update composer.json * Update * Update README.md * Update table-models.md * Update composer.json * Update DataTable.php * Update composer.json * Update DataTable.php * Update Middleware.php * Update middleware.md * Update middleware.md * Update composer.json * Update README.md * Update DataTable.php * Update composer.json * Update README.md * Update README.md * use Str::contains instead of str_contains, implode error (#18) * Updater to version 3.0.29 * Update README.md * Spelling / grammar (#19) * Update composer.json * Update DataTableServiceProvider.php * Update DataTable.php * Update ColumnBuilder.php * Update table-models.md * Update DataTable.php * Update composer.json * Update 3.0.32 * Fix ID issue * Update composer.json * Update number.blade.php * Update Number.php * Update composer.json * Fix issue with empty check * Version 3.0.35 * Update 3.0.36 * Update scripts.blade.php * Update composer.json * Fix sort issue * 3.0.38 * Fix issue in searchable keys * Update composer.json * Update README.md * Update README.md * Update README.md * Update php 7.4 (#22) * Update php 7.4 * Update README.md * Update checkbox.md * Update checkbox.md * Fix issue with pivot tables * 3.1.1 * Swapped overwrite with condition statement * Update 3.1.2 * Fix stub issue * Update MakeModel.php * Create tutorial.md * Update README.md * Update tutorial.md * Update tutorial.md * Update tutorial.md * Update tutorial.md * Update README.md * Added selected attribute * Added selected attribute * Added filter attributes * Fix issue in order with relations * Fixes issue in relation order * Fix issue in searchables * Update composer.json * Update checkbox.blade.php * Update composer.json * Code clean Plain javascript to classes and methods for cleaner code * Added object to the filter methods * Update 3.1.7 * Added number format method * Added format method for countings * Update 3.1.8 * Set condition check as first * Change condition line * Fix issue with method not found exception * Update 3.1.10 * Fix bug in sorting model * Update Multiple.php * Update multiple.blade.php * Update composer.json * Update Dropdown.php * Namespace fix * Update table-models.md (#27) Co-authored-by: Wimurk <wimurk@users.noreply.github.com> Co-authored-by: Anthimidis Nikos <kastoras_1@hotmail.com> Co-authored-by: Wim Pruiksma <wimpruiksma@gmail.com> Co-authored-by: Jimmy Yen <zeng.tw@gmail.com> Co-authored-by: Zachary Craig <zack@zack6849.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.