Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add: compilePrimary function to src/Schema/Grammar.php #52

Merged
merged 1 commit into from
Jan 16, 2023

Conversation

nickarellano
Copy link
Contributor

There was a PR that was accepted for laravel/framework:v9.47.0 that breaks primary keys with SingleStore.

[9.x] Remove index name when adding primary key on MySQL #45515

Expected query:

create rowstore table `cache` (
  `key` text not null,
  `value` text not null,
  `expiration` int not null,
  shard key(`key`),
  primary key (`key`)
) default character set utf8mb4 collate 'utf8mb4_unicode_ci'

Actual problematic query:

create rowstore table `cache` (
  `key` text not null,
  `value` text not null,
  `expiration` int not null,
  shard key(`key`),
  alter table
    `cache`
  add
    primary key (`key`)
) default character set utf8mb4 collate 'utf8mb4_unicode_ci'

@carlsverre carlsverre merged commit 421a569 into singlestore-labs:main Jan 16, 2023
@carlsverre
Copy link
Contributor

Thanks for the quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants