Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor AtomDB.get_matched_links to support nested lists in target_handles #191

Open
angeloprobst opened this issue Aug 14, 2024 · 0 comments

Comments

@angeloprobst
Copy link
Collaborator

angeloprobst commented Aug 14, 2024

Currently, AtomDB.get_matched_links expects a list[str] in the param target_handles.

But there are situations where the caller could have a list of lists (ie. ['a', 'b', ['c', 'd'], 'e', [['f', 'g', 'h'], ['i', 'j'], 'k'], 'l']) - this can happen when links point to other links.
Which is the case in this stack:

LocalQueryEngine.fetch(...)
    LocalQueryEngine._process_link(...)
		LocalQueryEngine._generate_target_handles(...)  # <-- this function builds a list with nested lists
			<backend>.get_matched_links(...)

There are no tests on das-query-engine and das-atom-db covering this scenario.

@angeloprobst angeloprobst self-assigned this Aug 14, 2024
@angeloprobst angeloprobst changed the title Add skipped test checking AtomDB.get_matched_links Refactor AtomDB.get_matched_links to support nested lists in target_handles Aug 14, 2024
@angeloprobst angeloprobst removed their assignment Aug 14, 2024
angeloprobst added a commit that referenced this issue Aug 14, 2024
…ure-evaluation

[#191] adding skipped test for future evaluation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant