Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #426: get number of free calls allowed from the service metadata #427

Merged
merged 2 commits into from
Dec 5, 2019

Conversation

anandrgitnirman
Copy link
Contributor

service metadata now has a place holder to define the number of free calls allowed .Give placeholders to use this field
More test cases for coverage and go fmt formatting

anandrgitnirman and others added 2 commits November 28, 2019 10:39
service metadata now has a place holder to define the number of free calls allowed .Give placeholders to use this field
More test cases for coverage and go fmt formatting
@coveralls
Copy link

Coverage Status

Coverage increased (+1.09%) to 32.167% when pulling 6ddfe72 on anandrgitnirman:freecall into 65dc8ab on singnet:master.

@vsbogd
Copy link
Member

vsbogd commented Nov 28, 2019

BTW @anandrgitnirman , simple word form like #426 or /issues/426 can be used to designate issue number in commit header. It is much shorter and readable doesn't have https://github.com/ prefix but still clickable. And it leaves place for short commit description.

See example here: 01387ba

@anandrgitnirman anandrgitnirman changed the title https://github.com/singnet/snet-daemon/issues/426 #426, get number of free calls allowed from the service metadata Nov 29, 2019
@anandrgitnirman anandrgitnirman changed the title #426, get number of free calls allowed from the service metadata Issue #426: get number of free calls allowed from the service metadata Nov 29, 2019
@vsbogd
Copy link
Member

vsbogd commented Dec 2, 2019

Looks good to me

@anandrgitnirman anandrgitnirman merged commit 8f98bb9 into singnet:master Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants