Updating Pytest #120
Updating Pytest #120
Conversation
Based on instructions at https://discuss.circleci.com/t/how-to-add-a-path-to-path-in-circle-2-0/11554/9
Adjust cache keys Assert version after (potential) installation Fixes #118
Signed-off-by: Vanessa Sochat <vsochat@stanford.edu>
Signed-off-by: Vanessa Sochat <vsochat@stanford.edu>
Signed-off-by: Vanessa Sochat <vsochat@stanford.edu>
Signed-off-by: Vanessa Sochat <vsochat@stanford.edu>
Signed-off-by: Vanessa Sochat <vsochat@stanford.edu>
|
okay, so one of the test errors is because the semantic version string isn't being correctly parsed for the 3.2.1 install. The Singularity version, installed from the release, is: Which technically should return true when we test again 3.2.1, but it doesn't. from semver import VersionInfo
cli.version_info() >= VersionInfo(3, 2, 1)
FalseWe can update to 3.2.0 (which I think should work) cli.version_info() >= VersionInfo(3, 2, 0)
True |
Signed-off-by: Vanessa Sochat <vsochat@stanford.edu>
…hich sometimes is returning unicode instead of str, thus doesnt parse and incorrectly returns None Signed-off-by: Vanessa Sochat <vsochat@stanford.edu>
Signed-off-by: Vanessa Sochat <vsochat@stanford.edu>
Signed-off-by: Vanessa Sochat <vsochat@stanford.edu>
|
Cool, we just got all green! Since this updates test for pytest, and a few other PRs are depending on this, I'm going to merge. I didn't update to use Python decorators for pytest, and we I've created an issue so we don't forget to do this. To summarize the issues that were getting in the way above:
|
Signed-off-by: Vanessa Sochat <vsochat@stanford.edu>
|
There are enough changes (and an added dependency) to warrant a version bump. I'll bump, merge, release, and then get back to the other issues discussed. |
|
How come there are so many changes here after #117 was merged? |
| @@ -76,6 +76,7 @@ disable=attribute-defined-outside-init, | |||
| no-member, | |||
| protected-access, | |||
| R, | |||
| unidiomatic-typecheck, | |||
There was a problem hiding this comment.
Why? Wouldn't isinstance(foo, str) work?
There was a problem hiding this comment.
I don’t know why, but it didn’t. The type was Unicode in Circle and it was best caught by checking for string. If I added Unicode to the isinstance list it would skip over and return None for the state. But this works.
| print('...Case 4. Check status of existing bundle.') | ||
| state = self.cli.oci.state(self.name, sudo=True) | ||
| self.assertEqual(state['status'], 'created') | ||
| if self.cli.version_info() >= VersionInfo(3, 2, 0): |
There was a problem hiding this comment.
IMO this isn't correct. Can you setup a test job with 3.2.0? I think the change was to 3.2.1 so this may fail
There was a problem hiding this comment.
Sure I’ll add to the other PR. If that doesn’t work do you know how to account for the last 1 in 3.3.1-1? The original check you had for >= 3.2.1 returned False.
This is a continuation of #117 to get the last Python 2 tests working.