Add options and writable to exec, shell, run #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vanessa Sochat <vsochat@stanford.edu>
Signed-off-by: Vanessa Sochat <vsochat@stanford.edu>
|
@JayjeetAtGithub you can test this fix. First, remove all previous spython versions. Do this until it tells you it is installed: pip uninstall spythonThen, clone this branch and install: git clone -b add/options-writabl https://github.com/singularityhub/singularity-cli
cd singularity-cli
python setup.py installAnd then try the commands that were not working for you! I've updated the docs here to show them as well. |
|
@vsoch Thanks a lot! All well now. |
|
Ready to merge? |
|
Yep 😄 |
|
You got it! Please give me a few minutes to release to pypi, I will post the link here when it's done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request will allow the user to specify a list of options to each of exec, shell, and run, and also if the execution should be
--writable. I've also updated the documentation (and docstrings) with these examples.This will close #138