Fixing parsing bug with singularity cli #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
currently, it is assumed the comments and sections come after the header. However, we need to allow comments before because it is not unheard of (although it seems rare) Signed-off-by: vsoch <vsoch@users.noreply.github.com>
|
I'm not sure about multi-stage builds, could be that the parser assigns these comments wrongly to the stage. But I'm not too deep in the parser that I'm sure whether that actually holds. |
|
@StopMotionCuber that sounds correct - I don't think Singularity had support for them when I developed this, so likely there will be issues. I'll merge and release here, and if you hit a multistage build bug please open another issue and we will fix it up :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently, it is assumed the comments and sections come after the header. However, we
need to allow comments before because it is not unheard of (although it seems rare). This will fix #180
Signed-off-by: vsoch vsoch@users.noreply.github.com