Ensuring that we always load defaults and then update with user settings #475
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
right now, when shpc is updated with new config values and the user has a custom setting, you can trigger an error if a needed value is missing. to get around this, we should laways load the default settings file first, and then override with custom settings given that the preferred settings are not == the default Signed-off-by: vsoch <vsoch@users.noreply.github.com>
Signed-off-by: vsoch <vsoch@users.noreply.github.com>
|
@marcodelapierre do you have some time to review? This is related to #473 |
|
thanks for pinging @vsoch ! should be able to work on SHPC later today |
|
did a quick test, it works, and it makes complete sense to me! |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, when shpc is updated with new config values and the user has a custom setting, you can trigger an error if a needed value is missing. to get around this, we should always load the default settings file first, and then override with custom settings given that the preferred settings are not == the default
Signed-off-by: vsoch vsoch@users.noreply.github.com