Skip to content

Fix broke image link for container tree #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix broke image link for container tree #100

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
21cff64
Update README.md
vladdoster Oct 28, 2020
c5db22a
Update examples/visualize/tree/container_tree/README.md
vladdoster Oct 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions examples/visualize/tree/container_tree/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,9 @@ The functions under analysis will help you show the contents of an image (folder

This will open up something that looks like this:

![../../img/files.png](../../img/files.png)
![container tree](/img/files.png)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the fix is intended for just GitHub (and you can confirm this will work to represent the root of the repository) this should be good to render in the README - I had a relative path before in the case that it was on a GitHub pages server (and it was a few levels too shallow).

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, I didn't think to check that. Looking now

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me know when you've had a chance to look!

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I apologize for the lapse in communication. Checking it now.


An [interactive demo](https://singularityware.github.io/singularity-python/examples/container_tree) is also available.
An [interactive demo](https://singularityhub.github.io/singularity-python/examples/container_tree) is also available.

It's suggested that you use a package so it will open automatically - note that if you specify an image file, it will need to be packaged, and the console will hang as it waits for you to type it in and press enter.

Expand Down