Refactoring to ease the way we define generated code #22

netbe · 2014-04-15T15:44:56Z

Let's make it easier to define generated code via template. The approach is to use mustache template.

use a template files (meaning code complexity can be handled by developer/user)
document syntax for template (see template keys)
easy to install via homebrew or pypi
can use a given set of template files
document templates wiki

getCommonDescriptionString and getHeaderDescriptionString

Given a simple scheme, diff between generated files and expected files

Use second template for source.m

…unction

ADD to_dictionnary got JSONScheme

Assuring code functionality while refactoring

…mobile/metaJSON into feature/refactor Conflicts: templates/machine.m.mustache

…etaJSON into feature/refactor

…upper_camelcase}}

netbe · 2014-05-20T11:31:41Z

@SanggeonPark i think this pull request need some review from you or anybody else.
@WarrenFaith for now the java remains the same, will basically just need an Android template to be wrote at some points. Also any inputs welcomed :)

netbe · 2014-12-16T16:05:15Z

@sinnerschrader-mobile/owners what should we do guys with this PR, merge?

All tests have failed since 2015-01-01 because the timestamp at the copyright notice of the generated files differs from the timestamp of reference file's copyright notice which is of 2014. This is fixed by replacing all occurences of the current year in the generated files with "2014". Keep in mind that even new reference files need a timestamp of 2014 for the tests to work.

Fixing tests broken due to copyright timestamp

* Removed "target" option from command line. * Deleted JavaCodeGenerator because it is not needed anymore.

Android code generation using Mustache templates

netbe · 2015-03-19T08:40:57Z

Todo before merging:

Android support
Fix Mustache mistakes "0" value for false #24
Fix Mustache does not now about date minValue/maxValue #25

@ben-efiz something else missing before merging to master?

ben-efiz · 2015-03-19T08:43:47Z

That should be enough. The rest we track issues/enhancments. @S2MBO you had some on your wishlist.

S2MBO · 2015-03-19T09:03:29Z

Maybe we should give a thought about the differences between https://github.com/sinnerschrader-mobile/metaJSON/blob/907a400817bd526d71e3c0c5078f400764542e91/doc/MetaJSONProtocol.md and https://github.com/sinnerschrader-mobile/metaJSON/wiki/Protocol.

For example, merging this right now would remove the ISO 8601 formatted date feature for ObjectiveC (was never implemented in Java).

netbe · 2015-03-19T09:27:45Z

Yes you're right, I was not really keen on adding this ISO8601 support at least not that way. I mean then we will need the subType iso8601 in the protocol and in the template.

If I remember it was for one project only, in that case with the new version, you would create your own template and replace the code for normal dates with one for iso8601.

Worst case I would add it as enhancement.

netbe · 2015-03-20T09:43:22Z

FYI I added the repo to a code static analyser, here's the report for the branch: https://landscape.io/github/sinnerschrader-mobile/metaJSON/2

Improved test portability to fix #28

netbe and others added 30 commits October 13, 2013 21:09

ADD First test on getHeaderDescriptionString

d08c5fa

Refactor code to use must ache templates

000025f

getCommonDescriptionString and getHeaderDescriptionString

Refactor getSourceDescriptionString

58e37e3

Update ignored files: default output folder

eb2342d

ADD tests on make function for Objc

66b0a4f

Given a simple scheme, diff between generated files and expected files

[WIP] ADD test for generated header

589b6fc

Use second template for source.m

Extract functions to write files out of the make function

63f90de

Refactor content of human header file

aea218a

Refactor human source file

206bd84

Cleanup make function, move creating machine source file to its own f…

f2dd295

…unction

start using python naming convention

5eb3fda

rename function to match responsibility

be69c1e

Rename generateHumanHeaderFile() to human_header_content()

7e3751e

Rename generateHumanSourceFile() to human_source_content()

fb39c4c

Rename generateSourceFile() to machine_Source_content()

25661e8

Removed unused functions

937d4b7

Moved includeHeaders to template for machineSourceFile

fb3ba3f

Moving all code source generation of machine code to template

939fc4b

ADD to_dictionnary got JSONScheme

ADD output files of test.json sample

e659804

Assuring code functionality while refactoring

Cleanup test on test_class.json for obj-c

7d6b3c2

ADD dump object for test.json

7173371

Refactor tests to reuse for test.json

1aabcfb

add notes about development

89924c2

add requirements for development

63ea444

add sample test for mustache

8195cb9

update template and test

15d2321

add handling methods

1fd6cd0

Merge branch 'feature/refactor' of https://github.com/sinnerschrader-…

e273e2d

…mobile/metaJSON into feature/refactor Conflicts: templates/machine.m.mustache

Fixes all tests

22aa920

Merge branch 'feature/refactor' of github.com:sinnerschrader-mobile/m…

5338115

…etaJSON into feature/refactor

François Benaiteau added 11 commits May 16, 2014 11:37

add extra info to version. devel version shows git revision

a06203f

clean options for command usage

cedad0f

update README

2ad6f26

change 'comment' template key to 'description'

c0cee17

Typo fixes

afaad91

uniform variableName and varName

edba73c

replace {{capitalizeVarName}} by {{#_upper_camelcase}}{{varName}}{{/_…

2748fb4

…upper_camelcase}}

remove sub key value for min/maxLength,min/maxValue, min/maxCount, regex

5549b4b

projectPrefix becomes prefix

3af890a

remove template keys csv, see wiki

587648c

replace {{humanClassName}} and {{machineClassName}}

d102ecd

S2MBO and others added 9 commits March 9, 2015 15:22

Merge pull request #23 from S2MBO/feature/refactor

13f0cfb

Fixing tests broken due to copyright timestamp

Added package parameter for Java code generation

26b6288

Templates for Android code generation

40cbdab

Unified Android and iOS code generation

16e5bb5

* Removed "target" option from command line. * Deleted JavaCodeGenerator because it is not needed anymore.

Renamed ObjectiveCCodeGenerator.py to SourceCodeGenerator

b587191

Respecting suffix in class names.

c35c5d8

Moved member variable's definitions up and added some whitespace.

d9c1bf9

Merge pull request #26 from S2MBO/feature/refactor

e1b249f

Android code generation using Mustache templates

netbe mentioned this pull request Mar 20, 2015

[Feature/refactor] Date Hack for tests is platform dependent #28

Open

S2MBO and others added 2 commits March 20, 2015 16:22

Improved test portability to fix #28

836833c

Merge pull request #29 from S2MBO/test_port

1cd0e33

Improved test portability to fix #28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactoring to ease the way we define generated code #22

Refactoring to ease the way we define generated code #22

netbe commented Apr 15, 2014

netbe commented May 20, 2014

netbe commented Dec 16, 2014

netbe commented Mar 19, 2015

ben-efiz commented Mar 19, 2015

S2MBO commented Mar 19, 2015

netbe commented Mar 19, 2015

netbe commented Mar 20, 2015

Refactoring to ease the way we define generated code #22

Are you sure you want to change the base?

Refactoring to ease the way we define generated code #22

Conversation

netbe commented Apr 15, 2014

netbe commented May 20, 2014

netbe commented Dec 16, 2014

netbe commented Mar 19, 2015

ben-efiz commented Mar 19, 2015

S2MBO commented Mar 19, 2015

netbe commented Mar 19, 2015

netbe commented Mar 20, 2015