Check deletion results before determining success/failure #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's possible for errors to exist in these results. For example, if the AWS
user has permission to list the buckets but does not have permission to delete
the bucket items.
Example logs (after applying this patch):
> Serverless: Failed: my-testing-bucket may not be empty.
> Serverless: `[[{"Key":"foo","Code":"AccessDenied","Message":"Access Denied"},{"Key":"bar","Code":"AccessDenied","Message":"Access Denied"}]]`
> S3 Remover: Failed: my-testing-bucket may not be empty.
jordan-brough
force-pushed
the
show-error-results
branch
from
6f0bbed to
edf01cb
Compare
|
@sinofseven, can you merge these pending pull requests and publish a new version please? I tried to use this plugin today and ran into the same AccessDenied error that was reported as success. |
|
@jordan-brough since this project is no longer maintained, I published a reimplemented plugin that includes the error checking you and I asked here, see note in #22 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should look to see if any errors are returned here.
It's possible for errors to exist in these results. For example, if the AWS
user has permission to list the buckets but does not have permission to delete
the bucket items.
Example logs (after applying this patch):