Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add type tests #373

Merged
merged 1 commit into from
Apr 16, 2021
Merged

chore: add type tests #373

merged 1 commit into from
Apr 16, 2021

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Apr 15, 2021

Purpose (TL;DR) - mandatory

#356 (comment)

I just added a dummy test, no attempt at coverage. But it's a good opportunity for new contributors if they want, and future changes to the types should include tests

- files: "**/*.ts"
parserOptions:
ecmaVersion: 2020
sourceType: 'module'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removes the syntax error for import, but still syntax error for type. Might be worth it to add @typescript-eslint/parser or something, but felt very out of scope

@codecov
Copy link

codecov bot commented Apr 15, 2021

Codecov Report

Merging #373 (9e1a23c) into master (c39e970) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #373   +/-   ##
=======================================
  Coverage   93.49%   93.49%           
=======================================
  Files           1        1           
  Lines         553      553           
=======================================
  Hits          517      517           
  Misses         36       36           
Flag Coverage Δ
unit 93.49% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c39e970...9e1a23c. Read the comment docs.

@mroderick
Copy link
Member

This looks like a good start to me. @SimenB can you think of any reason not to merge this?

@SimenB
Copy link
Member Author

SimenB commented Apr 16, 2021

Only reason would be if we wanted more tests before landing, but I think it's valuable as is 👍

@SimenB SimenB merged commit 07d90ce into sinonjs:master Apr 16, 2021
@SimenB SimenB deleted the type-tests branch April 16, 2021 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants