Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new mochify, update dependencies, drop old node #132

Merged
merged 11 commits into from
Dec 29, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
59 changes: 17 additions & 42 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,18 +9,11 @@ jobs:
static-analysis:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: mansona/npm-lockfile-version@v1
- uses: actions/setup-node@v2
- uses: actions/checkout@v3
- uses: actions/setup-node@v4
with:
node-version: "16"
- name: Cache modules
uses: actions/cache@v2
with:
path: ~/.npm
key: ${{ runner.os }}-node-${{ hashFiles('**/package-lock.json') }}
restore-keys: |
${{ runner.os }}-node-
node-version: "lts/*"
cache: "npm"
- name: Install dependencies
run: |
npm ci
Expand All @@ -35,20 +28,14 @@ jobs:
npm run lint

saucelabs-test:
if: ${{ github.ref == 'refs/heads/master' }}
if: ${{ github.ref == 'refs/heads/main' }}
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v2
with:
node-version: "16"
- name: Cache npm
uses: actions/cache@v2
- uses: actions/checkout@v3
- uses: actions/setup-node@v4
with:
path: ~/.npm
key: ${{ runner.os }}-node-${{ hashFiles('**/package-lock.json') }}
restore-keys: |
${{ runner.os }}-node-
node-version: "lts/*"
cache: "npm"
- name: Install dependencies
run: |
npm ci
Expand All @@ -64,17 +51,11 @@ jobs:
coverage:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v2
- uses: actions/checkout@v3
- uses: actions/setup-node@v4
with:
node-version: "16"
- name: Cache npm
uses: actions/cache@v2
with:
path: ~/.npm
key: ${{ runner.os }}-node-${{ hashFiles('**/package-lock.json') }}
restore-keys: |
${{ runner.os }}-node-
node-version: "lts/*"
cache: "npm"
- name: Install dependencies
run: |
npm ci
Expand All @@ -91,21 +72,15 @@ jobs:

strategy:
matrix:
node-version: [12, 14, 16]
node-version: [16, 18, 20]

steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v2
uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node-version }}
- name: Cache modules
uses: actions/cache@v2
with:
path: ~/.npm
key: ${{ runner.os }}-node-${{ hashFiles('**/package-lock.json') }}
restore-keys: |
${{ runner.os }}-node-
cache: "npm"
- name: Install dependencies
run: |
npm ci
Expand Down
10 changes: 0 additions & 10 deletions .min-wd

This file was deleted.

6 changes: 3 additions & 3 deletions lib/referee-sinon.js
Original file line number Diff line number Diff line change
Expand Up @@ -256,7 +256,7 @@ function createCalledOnceWith(ref) {

if (!spy.calledWith.apply(spy, slice(arguments, 1))) {
assertMessage = `Expected \${spyObj} to be called with arguments \${...expected}, but was called with ${argsAsString(
spy.args[0]
spy.args[0],
)}`;
return false;
}
Expand Down Expand Up @@ -318,7 +318,7 @@ function createCalledOnceWithExactly(ref) {

if (!spy.calledWithExactly.apply(spy, slice(arguments, 1))) {
assertMessage = `Expected \${spyObj} to be called once with exact arguments \${...expected}, but was called with ${argsAsString(
spy.args[0]
spy.args[0],
)}`;
return false;
}
Expand Down Expand Up @@ -367,7 +367,7 @@ function createCalledOnceWithMatch(ref) {

if (!spy.calledWithMatch.apply(spy, slice(arguments, 1))) {
assertMessage = `Expected \${spyObj} to be called once with matching arguments \${...expected}, but was called with ${argsAsString(
spy.args[0]
spy.args[0],
)}`;
return false;
}
Expand Down
Loading
Loading